MineOS icon indicating copy to clipboard operation
MineOS copied to clipboard

Security enhancement through salting

Open FrostyPenguin opened this issue 6 years ago • 1 comments
trafficstars

Hey, I just noticed that the passwords are stored in plain-hashed format using sha256. First off, it's awesome that it doesn't just store them in plain. However, when two users have the same password this results in the very same hash.

That's why in “real” OSes they salt the password. A two digit number that is prepended to the password before hashing and stored in plain alongside the hash is enough to make the system an awful lot stronger :smirk:.

I'd open a pull request if I was better in Lua programming (I'm a C fanboy). So if someone wants to give this a try before I do (probably not very soon), feel free to do so.

FrostyPenguin avatar Aug 13 '19 11:08 FrostyPenguin

Good point, maybe someday this will be added, thanks

IgorTimofeev avatar Aug 13 '19 15:08 IgorTimofeev