oidc-client-js icon indicating copy to clipboard operation
oidc-client-js copied to clipboard

Add "client_authentication" parameter to index.d.ts

Open andioli opened this issue 4 years ago • 3 comments

First of all, thank you for adding basic authentication with #1060.

Yet, the client_authentication parameter is still missing in the index.d.ts file. It would be great, if you could add this line: client_authentication: string to OidcClientSettings.

Without this parameter, it's not really usable with Typescript projects.

Thanks in advance! :)

andioli avatar Feb 26 '21 15:02 andioli

Feel free to send a PR, please?

brockallen avatar Feb 27 '21 22:02 brockallen

it should be: client_authentication? : string

can anybody make PR for this: in node_modules/oidc-client/index.d.ts I am not allowed to push changes

line 126: export interface OidcClientSettings { /** The URL of the OIDC/OAuth2 provider / authority?: string; readonly metadataUrl?: string; /* Provide metadata when authority server does not allow CORS on the metadata endpoint / metadata?: Partial<OidcMetadata>; /* Provide signingKeys when authority server does not allow CORS on the jwks uri / signingKeys?: any[]; /* Your client application's identifier as registered with the OIDC/OAuth2 / client_id?: string; client_secret?: string; /* The DefaultClientAuthentication is 'client_secret_post' and can be set back to standard 'client_secret_basic' / client_authentication? : string /* The type of response desired from the OIDC/OAuth2 provider (default: 'id_token') */

frontendplace avatar May 05 '21 13:05 frontendplace

Added this in #1390

willmcclellan avatar Jun 02 '21 00:06 willmcclellan