iouring-go icon indicating copy to clipboard operation
iouring-go copied to clipboard

Size of cq could be wrong (?)

Open d2gr opened this issue 3 years ago • 2 comments

Hello, I see that in this repo the size of the cq ring is using uint32Size instead of the CompletionQueueEntry's size. For reference, in liburing they use CompletionQueueEntry.

Your code https://github.com/Iceber/iouring-go/blob/b1dc8dd9fbfdd191b4e8f7ba8276c8aa4326a81b/mmap.go#L77

liburing: https://github.com/axboe/liburing/blob/a71d56ef3259216739677473ddb17ad861c3a964/src/setup.c#L29

size = sizeof(struct io_uring_cqe);
...
cq->ring_sz = p->cq_off.cqes + p->cq_entries * size;

d2gr avatar Sep 05 '22 10:09 d2gr

@d2gr Thanks, it does seem to be a serious bug.

Looks like I need to re-review this project,and start the development(alpha) of iouring-net.

Iceber avatar Sep 05 '22 10:09 Iceber

is this still an issue?

kant777 avatar Apr 13 '23 01:04 kant777