ITensorTDVP.jl icon indicating copy to clipboard operation
ITensorTDVP.jl copied to clipboard

Remove versions taking various argument orderings?

Open emstoudenmire opened this issue 3 years ago • 2 comments

Currently there are some interfaces like the tdvp function which have wrappers that allow passing the arguments in a different order, for example:

tdvp(H,psi,t, ...)

instead of

tdvp(H,t,psi,...)

Before finalizing this package, I would suggest we decide on a standard ordering for interfaces like this and remove the other orderings.

emstoudenmire avatar Oct 04 '22 20:10 emstoudenmire

One reason I like the second one is that it is more similar to the equation exp(Ht)|psi> (in fact we could consider calling tdvp something like exp or exponentiate, in a future where there are multiple MPO-based time evolution backends).

mtfishman avatar Oct 04 '22 21:10 mtfishman

Agreed that the second interface is nicer. I think we should just have one of them (since this package hasn't been released yet) so I'm happy with that one being the interface.

emstoudenmire avatar Oct 05 '22 03:10 emstoudenmire