dataverse-client-python icon indicating copy to clipboard operation
dataverse-client-python copied to clipboard

test_connect_unknown_failure gives SSLError when running against dev1

Open mdehollander opened this issue 7 years ago • 3 comments

dataverse/test/test_dataverse.py::TestUtils::test_get_element PASSED
dataverse/test/test_dataverse.py::TestUtils::test_get_elements PASSED
dataverse/test/test_dataverse.py::TestUtils::test_format_term PASSED
dataverse/test/test_dataverse.py::TestUtils::test_format_term_replace PASSED
dataverse/test/test_dataverse.py::TestConnection::test_connect PASSED
dataverse/test/test_dataverse.py::TestConnection::test_connect_unauthorized PASSED
dataverse/test/test_dataverse.py::TestConnection::test_connect_unknown_failure FAILED
dataverse/test/test_dataverse.py::TestConnection::test_create_dataverse PASSED
dataverse/test/test_dataverse.py::TestConnection::test_delete_dataverse PASSED
dataverse/test/test_dataverse.py::TestConnection::test_get_dataverses PASSED
dataverse/test/test_dataverse.py::TestConnection::test_get_dataverse PASSED
dataverse/test/test_dataverse.py::TestDataset::test_init PASSED
dataverse/test/test_dataverse.py::TestDataset::test_init_from_xml PASSED
dataverse/test/test_dataverse.py::TestDatasetOperations::test_create_dataset PASSED
dataverse/test/test_dataverse.py::TestDatasetOperations::test_add_dataset_from_xml PASSED
dataverse/test/test_dataverse.py::TestDatasetOperations::test_add_files PASSED
dataverse/test/test_dataverse.py::TestDatasetOperations::test_upload_file PASSED
dataverse/test/test_dataverse.py::TestDatasetOperations::test_display_atom_entry PASSED
dataverse/test/test_dataverse.py::TestDatasetOperations::test_display_dataset_statement PASSED
dataverse/test/test_dataverse.py::TestDatasetOperations::test_delete_a_file PASSED
dataverse/test/test_dataverse.py::TestDatasetOperations::test_delete_a_dataset PASSED
dataverse/test/test_dataverse.py::TestDatasetOperations::test_publish_dataset SKIPPED

Complete log: https://paste.ubuntu.com/p/8PjCBf5pxN/

mdehollander avatar Apr 18 '18 07:04 mdehollander

@mdehollander thanks for opening this issue and I'm glad #44 is resolved.

I took a quick look at the stack trace and the test but I can't figure out why it's failing. I'm not even sure what the purpose of this test is.

pdurbin avatar Apr 18 '18 12:04 pdurbin

I think what the test does is—

  • Registers a mock API endpoint so when you GET the service document, the mock endpoint returns a 400
  • Tries to create a connection
  • Asserts that a ConnectionError (custom client error) is thrown in that case

Looks like we're getting an SSL error instead, but the real issue is that we should only be hitting the mock endpoint. Not sure what's changed.

rliebz avatar Apr 21 '18 20:04 rliebz

@rliebz oh, interesting. Thanks for explaining this!

@mdehollander is running the tests against https://dev1.dataverse.org rather than any sort of mock endpoint so perhaps this test doesn't make any sense in that context? I don't know. I guess we should figure out if it passes or fails against the mock API endpoint.

pdurbin avatar Apr 21 '18 23:04 pdurbin