QtPass icon indicating copy to clipboard operation
QtPass copied to clipboard

Published 20 hours ago • verified publisher icon IJHack

Invalid font color with Breeze Dark theme

Open vanyasem opened this issue 7 years ago • 11 comments

I am running Arch GNU/Linux with KDE Plasma 5.11.4 (Qt 5.10.0)

I am using a dark theme (Breeze Dark), but unfortunately some fonts are rendered incorrectly and are impossible to read.

I tried both installing the package from repos and compiling it myself.

2017-12-30-024057_1602x968_scrot

vanyasem avatar Dec 29 '17 23:12 vanyasem

The same issue arises by enabling the "Global Dark Theme" in gnome 3 on fedora screenshot from 2018-02-02 16-41-46

daveol avatar Feb 02 '18 15:02 daveol

This should probably only use native theme colours instead of hardcoded colours.

annejan avatar Feb 02 '18 16:02 annejan

I can add to this. In most parts of qtpass my dark theme is respected in terms of color inversion, but not on "welcome screen". qtpass_dark-theme_fail Image shows qtpass-1.2.3 ~~I suspect the text colors are hardcoded.~~ yes, they are: https://github.com/IJHack/QtPass/blob/cc297302286a7e48d446531fe23224efb393cb5c/src/mainwindow.ui#L242-L251 and a few other localization/localization_xx_XX.ts files

Piraty avatar Jun 07 '18 08:06 Piraty

Same issue with macOS Mojave screenshot 2018-06-28 at 10 24 09 Qt is working on some of the issues, the rest might be easily fixable with some style changes.

annejan avatar Jun 28 '18 08:06 annejan

Fixed the HTML screenshot 2018-06-28 at 11 26 37 I don't like the blue, but I like adding hardcoded styles even less . .

Testing on KDE Breeze Dark asap 😸

annejan avatar Jun 28 '18 09:06 annejan

Can you please use system colors and not hard code any color?

alxlg avatar Jun 25 '19 10:06 alxlg

Hello! Thanks for the handy app! Looks like it's possible just to drop the hardcoded color:#0000ff value at the src/configdialog.ui and src/mainwindow.ui to fix the issue, am I right? :thinking: Checking with Qt 5.13, KDE Plasma 5.16 (yet another arch fanboy), looks like html without specified color renders correctly according to the system-wide theme? (For example, at the config dialog version info)

Imgur Imgur

a-andreyev avatar Sep 25 '19 21:09 a-andreyev

I still see this problem on macOS (QtPass 1.3.2). 🧐

screen

pheraph avatar Oct 17 '19 13:10 pheraph

the dark blue hyperlink color seems to be inherited from system/qt, since i have that in quiet a lot applications (along: texstudio, quassel), so i suspect a general theming issue

Piraty avatar Oct 17 '19 15:10 Piraty

This does not seem to be the case this time @Piraty Screenshot 2019-10-17 at 18 04 41 I have sanitised the HTML content of the start screen. Unfortunately QtCreator automagically places <span> the markup back . . @Piraty was right after all 😉

So I edited the mainwindow.ui file and replaced the HTML for clean HTML . .

Now it looks like this (macOS dark) . . Screenshot 2019-10-17 at 18 31 38

So no improvement there . . except for size and spacing 😞

annejan avatar Oct 17 '19 16:10 annejan

I'm taking this up with Qt . . Along with the inherited transparency of context menu's . . Screenshot 2019-10-17 at 18 39 24

annejan avatar Oct 17 '19 16:10 annejan