idaes-pse icon indicating copy to clipboard operation
idaes-pse copied to clipboard

_enthalpy_flow_term incorrectly used under _energy_density_term in generic modular property scaling

Open aspitarl opened this issue 8 months ago • 1 comments

When running calculate_scaling_factors with a generic property and _energy_density_term it appears that the code has a typo that tries to incorrectly set the scaling factor of _enthalpy_flow_term

https://github.com/IDAES/idaes-pse/blob/5f3b33bf6ffdce40b085fab16820eb7d9812f67c/idaes/models/properties/modular_properties/base/generic_property.py#L2243-L2244

After changing this to self.energy_density_term I was able to calculate scaling factors correctly.

aspitarl avatar Mar 04 '25 23:03 aspitarl