idaes-pse icon indicating copy to clipboard operation
idaes-pse copied to clipboard

Widespread test failures with Ubuntu 24.04, including `ubuntu-latest` GHA runner image

Open lbianchi-lbl opened this issue 1 year ago • 0 comments
trafficstars

Symptoms

Widespread test failures (hundreds of tests failing), with error messages involving solvers and/or external functions not being found: e.g. from https://github.com/IDAES/idaes-pse/actions/runs/11286619805/job/31391269153

image

Probable cause

  • Sometimes in the last few days, the ubuntu-latest GHA runner image was updated so that it now points to Ubuntu 24.04 (ubuntu-24.04) from the previous default of ubuntu-22.04 image
  • To the best of my knowledge, idaes-ext does not have a build for Ubuntu 24.04, and idaes get-extensions reports as much, but does not seem to raise an error: image

When will things work/not work?

  • If the GitHub Actions runner image is specified as ubuntu-20.04 or ubuntu-22.04, we expect things to work (i.e. tests should pass): https://github.com/IDAES/idaes-pse/blob/0e05ed1410b83b5509efe68aa9e49026404e8db0/.github/workflows/core.yml#L97
  • If the GHA runner image is specified as ubuntu-latest (or ubuntu-24.04), we expect things to not work (i.e. most if not all tests involving solvers and/or external functions): https://github.com/IDAES/idaes-pse/blob/0e05ed1410b83b5509efe68aa9e49026404e8db0/.github/workflows/core.yml#L228
  • The above only applies to code that solves IDAES models (i.e. code that normally would fail if IDAES extensions are not available). Anything else (e.g. spell checker, Pylint, utility CI jobs) should continue to work with ubuntu-latest/ubuntu-24.04

Possible remedies

  • Short-term: update the failing GHA jobs to specify runs-on: ubuntu-22.04
  • Long(er) term:
    • Add support for Ubuntu 24.04 in the IDAES extensions
    • Consider adding logic (perhaps requiring an optional flag, e.g. idaes get-extensions --strict or something) so that idaes get-extensions exits with failure if a supported/compatible platform is not found

lbianchi-lbl avatar Oct 11 '24 14:10 lbianchi-lbl