idaes-pse icon indicating copy to clipboard operation
idaes-pse copied to clipboard

Diagnostics tool for ill-posed constraints

Open andrewlee94 opened this issue 1 year ago • 8 comments
trafficstars

Waiting on https://github.com/Pyomo/pyomo/pull/3376

Summary/Motivation:

As part of working on the new scaling tools, I realised there are some simple checks we can do for detecting poorly-posed constraints that could cause scaling issues. This PR adds a new expression walker that looks for the following signs of poor scaling in constraints:

  • sum expressions with terms which have significant differences in magnitude.
  • sum expressions where terms cancel out (with a catch for cases of constant == sum()).

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

andrewlee94 avatar Jul 22 '24 20:07 andrewlee94