pyPESTO icon indicating copy to clipboard operation
pyPESTO copied to clipboard

AmiciObjective: check that sensitivities wrt all relevant parameters …

Open dweindl opened this issue 1 year ago • 1 comments

…can be computed

Adds a check whether the amici model in an AmiciObjective is able to compute sensitivities w.r.t. to the objective parameters.

Closes #1414

This raised the question of whether an objective can have implicitly fixed parameters. I.e. whether it should be considered a use case, that some objective parameters that may change the objective value, have zero entries in the gradient. This is what's happening if one uses PetabImporter.create_objective() without passing it through PetabImporter.create_problem(). So far, pypesto is rather unclear on that. Whether this affects optimization will depend on into which Problem this objective will be put.

My assumption here is that this is undesirable and that changes in the objective value should be reflected in the gradient.

dweindl avatar Jun 17 '24 09:06 dweindl

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 31.05%. Comparing base (0bf7f36) to head (f107c48).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1416       +/-   ##
============================================
- Coverage    83.88%   31.05%   -52.83%     
============================================
  Files          160      160               
  Lines        13096    13105        +9     
============================================
- Hits         10985     4070     -6915     
- Misses        2111     9035     +6924     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 17 '24 12:06 codecov-commenter