pyPESTO icon indicating copy to clipboard operation
pyPESTO copied to clipboard

Select: support user-provided calibration results

Open dilpath opened this issue 1 year ago • 1 comments

Currently, the design is that:

  • a user can provide previously-calibrated models as user_calibrated_models
  • PEtab Select will put these models into the candidate space, instead of the uncalibrated versions
  • pyPESTO still needs to skip these models

The purpose is that the path through model space is still reproducible, because models are not skipped. TODO: fully handle this in PEtab Select, so pyPESTO never sees already-calibrated models, except when it asks PEtab Select for the final results.

dilpath avatar Mar 26 '24 12:03 dilpath

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.71%. Comparing base (d5eedc2) to head (0fdfae0).

Files with missing lines Patch % Lines
pypesto/select/method.py 86.66% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1338      +/-   ##
===========================================
- Coverage    82.77%   82.71%   -0.06%     
===========================================
  Files          163      163              
  Lines        13907    13910       +3     
===========================================
- Hits         11511    11506       -5     
- Misses        2396     2404       +8     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 26 '24 12:03 codecov-commenter

Now handled on the PEtab Select side

dilpath avatar Nov 11 '24 23:11 dilpath