sarama
sarama copied to clipboard
IBM
feat: add default SCRAMClientGeneratorFunc
Make the client generator in the example used as the default SCRAMClientGeneratorFunc automatically when the user set the SASL.Mechanism as sarama.SASLTypeSCRAMSHA256 or sarama.SASLTypeSCRAMSHA512 in config.go.
When I am using the config, I think the client should be automatically generated according to my configuration but not telling me kafka: invalid configuration (A SCRAMClientGeneratorFunc function must be provided to Net.SASL.SCRAMClientGeneratorFunc). When I'm stepping into the imported source code, it is a little bit hard for me to target the useful GeneratorFunc because Golang import without the examples.
But when I tried to edit the config.go, I thought the best way to add the default GeneratorFunc is in the Validate function, it isn't a config generator. This is a point that I think may need to be discussed.
Hi.
Any chances to move this PR forward?
Merged upstream. It seems @bai is not active now, maybe @dnwe can help for review ?
Hey @liangxj8 - I moved on to other things and have no commit rights anymore.
Maybe @d1egoaz @methodmissing would be able to chase committers internally as well 🙏🏼
Thank you for your contribution! However, this pull request has not had any activity in the past 90 days and will be closed in 30 days if no updates occur. If you believe the changes are still valid then please verify your branch has no conflicts with main and rebase if needed. If you are awaiting a (re-)review then please let us know.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thank you @liangxj8 this worked perfektly form my project and saved me a hole lot of time!
Thank you for your contribution! However, this pull request has not had any activity in the past 90 days and will be closed in 30 days if no updates occur. If you believe the changes are still valid then please verify your branch has no conflicts with main and rebase if needed. If you are awaiting a (re-)review then please let us know.