sarama icon indicating copy to clipboard operation
sarama copied to clipboard

fix:bugFix add retry for offset commit

Open HobbyBear opened this issue 4 years ago • 3 comments
trafficstars

Fixes #1562 #1758 The reason for the timeout when submitting the offset is likely to be the rebalance caused by the server restart or expansion and contraction, and a jittery retry strategy needs to be added.

HobbyBear avatar Sep 22 '21 18:09 HobbyBear

@HobbyBear thanks for putting together these changes. They look reasonable to me, but I have a couple of questions:

  1. Please could you add some unittest coverage for the new behaviour?
  2. As an OffsetCommitRequest for a consumer group can contain offsets for multiple topic+partition combinations and the returned errors are similarly per topic+partition, I'm assuming that it is also possible for the OffsetCommitResponse to contain partial failures amongst some successes. In this code path we'll retry the OffsetCommitRequest as a whole even though some offsets may have been committed successfully, do we need to be filtering those out before the retry or is the broker happy to accept repeated commits for those? I wonder what the Java client does

dnwe avatar Oct 13 '21 09:10 dnwe

@HobbyBear 👋🏼 Friendly bump 🙏🏼 Could you please take a look at the comment above? I'd love to get this one shipped.

bai avatar Jan 21 '22 08:01 bai

@HobbyBear 👋🏼 Friendly bump 🙏🏼 Could you please take a look at the comment above? I'd love to get this one shipped.

Sorry, I've been a little busy recently. I'm still researching how the java client does retry, and it may not be so fast to get the results.

HobbyBear avatar Jan 26 '22 07:01 HobbyBear

Has this problem not been solved yet?

JKeita avatar Jul 26 '23 01:07 JKeita

Thank you for your contribution! However, this pull request has not had any activity in the past 90 days and will be closed in 30 days if no updates occur. If you believe the changes are still valid then please verify your branch has no conflicts with main and rebase if needed. If you are awaiting a (re-)review then please let us know.

github-actions[bot] avatar Nov 23 '23 00:11 github-actions[bot]