platform-services-go-sdk
platform-services-go-sdk copied to clipboard
fix(Resource Controller): Remove aliases and bindings
PR summary
Remove SDK references for CF aliases and bindings
PR Checklist
Please make sure that your PR fulfills the following requirements:
- [ ✓] The commit message follows the Angular Commit Message Guidelines.
- [ ] Tests for the changes have been added (for bug fixes / features)
- [✓ ] Docs have been added / updated (for bug fixes / features)
Current vs new behavior
The current behaviour has SDK references for CF aliases and bindings, new behaviour has the references for CF aliases and bindings are removed
Does this PR introduce a breaking change?
- [✓ ] Yes
- [ ] No If any users are using references for aliases and bindings SDK, then the users should be aware that aliases and bindings are no longer supported in RC
Other information
https://cloud.ibm.com/apidocs/resource-controller/resource-controller The APIDocs are updated to remove references for CF aliases and bindings
Hi @apoorva9s14 , it looks like your PR build failed because the resource-controller's examples still have references to things that were apparently removed. In your sandbox, you can run make all and it will run all the project's unit tests, plus run the linter on all unit/integration test and the examples code.
@apoorva9s14 Should I merge this PR in now, or are you still planning to make similar changes in the other three SDK projects (Java, Node.js, and Python)? If you are still planning to open PRs in the other SDK projects, then I can wait and merge them all at the same time. But, this PR has been opened for quite a while so I'm not sure what the priority level is on getting this merged in. Please advise.
I close this PR due to inactivity. Feel free to re-open if you need it in the future!