data-prep-kit icon indicating copy to clipboard operation
data-prep-kit copied to clipboard

fix change scancode-toolkit version in header_cleanser

Open shivdeep-singh-ibm opened this issue 1 year ago • 3 comments

Why are these changes needed?

To fix this failing build.

Related issue number (if any).

shivdeep-singh-ibm avatar Sep 23 '24 09:09 shivdeep-singh-ibm

Hi, @shivdeep-singh-ibm I was trying to fix a notebook that @ykalathiya has created for this transform in #845 and saw a problem with pip installing scancode-toolkit. The way I fixed that notebook was to pip install scancode-toolkit without any version number and it installed the latest version of scancode-toolkit for my venv and everything worked. Is there any problem if we don't specify the version number in the requirements.txt and the pyproject.toml files for this transform?

shahrokhDaijavad avatar Dec 18 '24 22:12 shahrokhDaijavad

@shivdeep-singh-ibm as you are updating the code transform models -can you fix this also ? We can get the PR merged then. Thanks

agoyal26 avatar Mar 10 '25 04:03 agoyal26

@ykalathiya @Param-S Please see this and request you to get this closed and fixed. Thanks

agoyal26 avatar Mar 21 '25 08:03 agoyal26