IBM
fix: updates web2parquet DataAccessLocal usage
954f1ba938bcc1300b2965f2647a45673ae54bd3 -> changes local_config to config in DataAccessLocal init
- updates dpk_web2parquet/transform usage of DataAccessLocal to match the change in config key name usage
- fixes reported issue https://github.com/data-prep-kit/data-prep-kit/issues/1410
Why are these changes needed?
DataAccessLocal constructor was previously changed to a unified key pattern with the other DataAccess types. This corrects what appears to be the last remaining use pattern of a DataAccessLocal using the local_config={} pattern.
Related issue number (if any).
https://github.com/data-prep-kit/data-prep-kit/issues/1410
Working out fine-tuning pipeline for granite 4 models, this bug came up in the start of the pipeline for crawling a web-resource. Think I covered anything necessary for contributing from what I can tell in the CONTRIBUTING.md.
Hi, @friezzren. Thank you for catching/fixing this! We appreciate your contribution. Before we can merge your change, you need to do a little work that contributing to the repo requires (sorry about the extra work):
As you can see from the red flag for merging, a PR cannot be merged until all signatures are "verified". For instructions on how to get verified signatures, please see here. After following these instructions, please do a quick test by adding a "trivial" commit to this PR and see the verified box next to your commit (see the example picture below for one of my commits)
If you see the verified box, then please open a new PR with everything that is in this PR and submit that (and close this one).
One more thing: In the same CONTRIBUTING.MD file above, I have now submitted a PR (it should be merged by the time you see this comment) to add a requirement for installing pre-commit (under Coding style guidelines) for all new PRs. Please do that too.
@shahrokhDaijavad Oh funky, thought I had that configured when I submitted, as I had made sure to review the contribution guidelines prior. I'll fix that up, and see about the pre-commit too. Thanks!