HouraiLauncher icon indicating copy to clipboard operation
HouraiLauncher copied to clipboard

Launcher is broken on macOS

Open mokou opened this issue 8 years ago • 4 comments

By default the filesystem on macOS is case-insensitive. Since the folder the launcher executable tries to write to is named Launcher it fails and crashes fairly early on.

A workaround that should work is renaming launcher to anything else, but when I do that it tries to download updates for whatever it's named instead of launcher.

When reporting a bug/issue:

  • Fantasy Crescendo Version: N/A
  • Operating System: macOS
  • Expected Behavior: A working launcher
  • Actual Behavior: The launcher crashes
  • Steps to reproduce the behavior:
  1. run ./launcher
  2. It crashes

mokou avatar Jul 21 '17 22:07 mokou

This is a design error, the fetched binary shouldn't depend on the local launcher binary's name.

james7132 avatar Jul 21 '17 22:07 james7132

Should be fixed as of 014a54b64bfbdbae478f4325d23399ac9ff1ef66, does this still occur?

james7132 avatar Jul 29 '17 07:07 james7132

Works now, but if I keep the default name it downloads as (launcher.dms) it still crashes trying to download a non-existent file. Renaming it to launcher works though.

mokou avatar Jul 29 '17 19:07 mokou

We'll probably resolve this by creating a *.app instead of a standalone launcher. Apparently not using --onefile on PyInstaller will do so.

james7132 avatar Aug 24 '17 00:08 james7132