homebrew-core icon indicating copy to clipboard operation
homebrew-core copied to clipboard

poppler: allows build on Sierra and High Sierra and fixes glib-utils problem

Open lukaso opened this issue 3 years ago • 4 comments

  • [x] Have you followed the guidelines for contributing?
  • [x] Have you ensured that your commits follow the commit style guide?
  • [x] Have you checked that there aren't other open pull requests for the same formula update/change?
  • [x] Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • [x] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • [x] Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

lukaso avatar Jul 27 '22 13:07 lukaso

@cho-m can we get this one merged? All looks good. Thanks!

lukaso avatar Jul 28 '22 16:07 lukaso

Patch has been submitted upstream, but rejected by maintainer as not something he's willing to support (too old OS version).

lukaso avatar Aug 06 '22 17:08 lukaso

This is the diff that would be the patch: https://gitlab.freedesktop.org/lukaso/poppler/-/merge_requests/1

lukaso avatar Aug 06 '22 17:08 lukaso

Patch has been removed so this will allow building from High Sierra (10.13). Sierra (10.12) would require the patch (see above).

lukaso avatar Aug 06 '22 18:08 lukaso