homebrew-cask
homebrew-cask copied to clipboard
deepl: update livecheck and legacy versions
The existing implementation of DeepL used regex to search for the 'most recent' version, which could often result in finding incorrect pre-release versions. (See https://github.com/mangerlahn/Latest/issues/447)
I've simplified this down to just using https://www.deepl.com/macos/download/DeepL.dmg which will always point to the latest release version, and I've removed the no longer supported legacy versions.
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions <cask> is the token of the cask you're submitting.
After making any changes to a cask, existing or new, verify:
- [x] The submission is for a stable version or documented exception.
- [x]
brew audit --cask --online <cask>is error-free. - [x]
brew style --fix <cask>reports no offenses.
It makes sense to update the livecheck to use the Sparkle feed. However, we should continue using the versioned URL, as it allows for the computation of checksums.
Instead of removing the legacy versions, we could use skip "Legacy version" in the livecheck block for macOS Catalina and older, as they no longer receive updates.
Keeping the livecheck makes sense but I'm not sure I agree on keeping all the legacy versions.
They used to be listed on deepl.com, but they've now been removed and no support for them is offered.
Keeping the livecheck makes sense but I'm not sure I agree on keeping all the legacy versions.
I don't see any downside to keeping the legacy versions unless they are known to have issues or make the cask harder to maintain. @bevanjkay, I would love your thoughts on this.
As long as the download URLs for the legacy versions work, I also don't see a reason for removing them.