bin/brew: remove HOMEBREW_NO_ENV_FILTERING.

[MikeMcQuaid]

trafficstars

It's been deprecated for a long time. Add a disabling message to be nice (that we'll remove in future).

---

This should probably wait for the next major/minor release, to be a bit nicer.

[BrewTestBot]

Review period will end on 2022-07-25 at 09:48:45 UTC.

[Bo98]

This should probably wait for the next major/minor release, to be a bit nicer.

Could potentially change the message to indicate that it will be the next release. Maybe also do things that make it more obvious like colouring etc.

I think we've now covered everything I've heard people need to turn env filtering off for so far (e.g. removing the dev-gating of HOMEBREW_{GIT,CURL}_PATH).

[MikeMcQuaid]

Could potentially change the message to indicate that it will be the next release.

I feel like given we don't know what the number/date will be it doesn't really communicate much?

Maybe also do things that make it more obvious like colouring etc.

Need to handle NO_COLOR and non-TTY cases and don't really want to just for this.

I think we've now covered everything I've heard people need to turn env filtering off for so far (e.g. removing the dev-gating of HOMEBREW_{GIT,CURL}_PATH).

There's also random formulae asking for people to do this but they can just ask people to instead set HOMEBREW_SOMETHING_RANDOM and then do the ENV["SOMETHING_RANDOM"] = ENV["HOMEBREW_SOMETHING_RANDOM"] in the formula.

[Bo98]

I feel like given we don't know what the number/date will be it doesn't really communicate much?

Possibly. I would've guessed we'd have a minor version Octoberish (macOS 13 release) but I guess it depends what else is planned.

[Bo98]

Need to handle NO_COLOR and non-TTY cases and don't really want to just for this.

Honestly surprised we didn't have something which already handles this so I guess it's not worth it if it's just this.

Edit: oh we do, but it's a different file: https://github.com/Homebrew/brew/blob/2b01354f2f8cdbf1315dce4f063b54cdecf95663/Library/Homebrew/brew.sh#L121-L135

[carlocab]

This should probably wait for the next major/minor release, to be a bit nicer.

I'd prefer to do something like this. I don't think it hurts too much for us to carry it around that much longer. On the other hand, I can see some people getting very upset over its sudden removal (yes, despite the warning messages).

Could potentially change the message to indicate that it will be the next release.

I feel like given we don't know what the number/date will be it doesn't really communicate much?

Let's pick a date and remove it on the first major/minor release after that. The date can be part of the warning message.

[BrewTestBot]

Review period ended.

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.