Results 84 comments of Himangini
trafficstars

We need to wait for eksctl v1 before proceeding with this change.

@cPu1 can you add more details of the tests in question here? which test needs to be updated?

> We have a merged [PR](https://github.com/weaveworks/eksctl/pull/4338) that we had to revert temporarily, that will remove the need for installing the VPC controller in order to run Windows workloads, making this...

Thanks for your request, after discussing with the team we decided we won't be implementing this functionality anytime soon. The workaround exists and it's a bit complicated to find the...

@johnwesley are you still working on this? let us know if you need any help or we can wrap this up 👍🏻

Can you resolve the conflicts please, we'll get this reviewed right away ✨ Edit: Also it'll be awesome if you can share any output of your manual testing please 👍🏻

> I've cleaned up the conflicts, but `make check-all-generated-files-up-to-date` wants to revert back to version 1 (see below), so I have missed some updates. I will have another pass. @johnwesley...

> Still receiving the same errors from `make test` @Himangini . I've updated `eksctl/pkg/eks/mocks/mocks.go` with the updated imports. I'm not familiar with mockery and will need to dig into it...

> There's also `eksctl/pkg/eks/api.go` vs `eksctl/pkg/eks/apiv2.go`. Is `api.go` scheduled for deprecation? Not sure, not atm AFAIK. I'll check and confirm.