Nathan Ridge

Results 1185 comments of Nathan Ridge

Thanks, I now see the `codeAction` request sent when text is selected in the log, and I can see that the response from the server does not contain an "extract...

It might be worth trying with the latest snapshot release (https://github.com/clangd/clangd/releases/tag/snapshot_20230917), to rule out any issues that may have been fixed since clangd 16.

Well, now I feel silly, because after all that analysis of logs, I checked the code and there is a check which disables the refactoring in language modes other than...

> there is a check which disables the refactoring in language modes other than C++ [right there](https://searchfox.org/llvm/rev/73c6248cc2cc3acd01c3580bfdc64825c09a0fd6/clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp#873-874)... The limitation was added in https://reviews.llvm.org/D85727. The reasoning given is: "This tweak uses...

Transferred to the clangd repo since this is a server-side enhancement.

The effect of enabling `semanticTokenColorCustomizations` seems to just be that it enables semantic highlighting if it isn't already enabled. (There is also a setting to enable it independently of any...

`VisitStringLiteral()` in `InlayHints.cpp` makes an unconditional call to `StringLiteral::containsNonAscii()`, but it looks like that function has as its precondition that `getCharByteWidth() == 1`. Adjusting the condition in the caller to...

It looks like clangd does not like the flag `-march=armv8-a` in the compile command, can you try removing it by creating a `.clangd` file with: ```yaml CompileFlags: Remove: [-march=*] ```

Another thing that could be worth investigating here is whether it's expected for `TemplateTypeParmTypeLoc::getDecl()` to return `nullptr` in this scenario. I know `TemplateTypeParmType::getDecl()` has a branch which returns `nullptr`, but...

> it seems a bit suspicious to me that this branch is taken for a TemplateTypeParmType**Loc** , which is supposed to represent a written-down instance of a `TemplateTypeParmType` in the...