puter
puter copied to clipboard
issue#696 solved
in line no 39 of src/gui/src/UI/UIWindowLogin.js a boolean variable added showSignupButton true means signup button will be visible and false means signup button will be disable
Hello, thanks for this contribution. There are a few changes that need to be made before we can merge this:
- Configuration: end-users won't know how to edit the code to change this property, so it needs to be a configuration value instead. A configuration value can be passed to gui using something called a "feature flag". Take a look at the one recently added to ACLService - this would be similar, except it would probably be registered by AuthService instead.
- Backend functionality: in its current state, this change might give users a false sense of security if they don't realize someone can still create accounts on their server by manually sending HTTP requests. The
signup.jsfile will need to be updated to not create temporary users on this condition.
Hello, I'm going to close this PR since we would like to implement this differently. I added instructions to #696 describing the ideal implementation.