SCEE icon indicating copy to clipboard operation
SCEE copied to clipboard

Published 20 hours ago • verified publisher icon Helium314

Allow overriding country restrictions

Open mnalis opened this issue 6 months ago • 10 comments

... in some quests only (where there is no community opposition; i.e. it is blocked due to spamminess or expert knowledge requirements. Few quests are added, the list may be extended upon request.

Please suggest which of the other quests user should be able to override (and which should not!)

Fixes: https://github.com/Helium314/SCEE/issues/619

Here is latest debug .apk for testing. Feedback welcome!

Should be implemented for ( :heavy_check_mark: means already finished!)

  • [x] AddFireHydrantDiameter.kt
  • [x] AddFireHydrantRef.kt
  • [x] AddSummitRegister.kt
  • [x] AddSummitCross.kt
  • [x] AddPostboxRef.kt
  • [x] AddPostboxCollectionTimes.kt
  • [x] AddBusStopRef.kt
  • [x] AddTactilePavingSteps.kt
  • [x] AddTactilePavingCrosswalk.kt
  • [x] AddTactilePavingKerb.kt
  • [x] AddTactilePavingBusStop.kt
  • [x] AddEntranceReference.kt
  • [x] AddRailwayPlatformRef.kt

Should (probably) not be implemented for ( :heavy_check_mark: means verified it should NOT be overriden):

  • [x] AddProhibitedForPedestrians.kt - no GB (community poll)
  • [x] AddRoadName: no, roads in Japan don't have names
  • [x] AddPoliceType: no, specific to italy
  • [ ] AddTrafficSignalsVibration.kt - ?? quest was requested to be disabled in those countries, but reason was being spammy / useless
  • [ ] AddCycleway: ??, seems to be restricted because spammy
  • [ ] AddMaxSpeed: ??, "generic" limits are useless and should not be added
  • [ ] DetermineRecyclingGlass: ??, spammy / useless in CZ and maybe was requested to be disabled
  • [x] AddAddressStreet.kt - no JP; "In Japan, housenumbers usually have block numbers, not streets"
  • [ ] AddMopedAccess.kt - mostly BE specific
  • [ ] AddIsPharmacyDispensing.kt - few countries indicated it is useless there, so only they are excluded
  • [ ] AddBusStopName.kt - only US, CA opted out, so only they are excluded
  • [ ] AddToiletsFee.kt - only US, CA opted out, so only they are excluded
  • [ ] AddHousenumber.kt - several countries opted out, so only they are excluded
  • [x] AddPostboxRoyalCypher.kt - only exists is several countries (if any more exist, they should be enabled for them!)
  • [ ] AddAcceptsCash.kt (maybe? too spammy?)
  • [ ] AddFuelSelfService.kt - (maybe: but spammy in most countries?)

mnalis avatar May 03 '25 17:05 mnalis

rusty-snake avatar May 03 '25 18:05 rusty-snake

Had a look at a few quests (thanks for the links @rusty-snake), and my opinion whether to allow override; AddRoadName: no, roads in Japan don't have names AddTrafficSignalsVibration: ??, quest was requested to be disabled in those countries, but reason was being spammy / useless AddSummitRegister: yes AddSummitCross: yes AddFuelSelfService: yes AddCycleway: ??, seems to be restricted because spammy AddPostboxRef: yes AddMaxSpeed: ??, "generic" limits are useless and should not be added AddPoliceType: no, specific to italy AddPostboxCollectionTimes: yes AddAcceptsCash: yes DetermineRecyclingGlass: ??, spammy / useless in CZ and maybe was requested to be disabled

Helium314 avatar May 04 '25 14:05 Helium314

Thanks @rusty-snake & @Helium314!

I've updated list at the top, as to start with those which should be not problematic, so I can do this PR with them (other quests can always be added later if people ask for them)...

If anybody has further opinions on those in "probably should not be implemented" (or of course in the "Should be implemented" list!) let me know.

mnalis avatar May 06 '25 01:05 mnalis

debug .apk for test here, if someone wants to try it out and let me know how it works for them.

mnalis avatar May 06 '25 02:05 mnalis

@rusty-snake @FloEdelmann any opinions on the current list? Looks fine to me.

Helium314 avatar May 10 '25 08:05 Helium314

Not an expert in all topics but the current list looks good (overall).

AddAcceptsCash.kt

It is to spammy in some countries/regions/cities where cash/cash-only is the norm. However it is a NoCountriesExcept with 4 countries and I expected that there are more countries (or parts like big cities) where it could be interesting.

Is there some kind of warning when overriding country restrictions?

rusty-snake avatar May 10 '25 09:05 rusty-snake

Right, it could be useful in some areas.

Is there some kind of warning when overriding country restrictions?

Currently not, only this text is shown below the setting: "Allow quests to be asked everywhere, even if originally disabled in some countries. Note that some quests still may not be overridden due to community consensus."

Helium314 avatar May 10 '25 09:05 Helium314

Is there some kind of warning when overriding country restrictions?

Not currently, because it looked somewhat complex in similar examples I found (and I don't know enough Kotlin to add it simpler way). :sweat_smile:

But I probably should add a warning anyway (even if original idea was to override only quest where it is quite unlikely anybody will complain about overtagging, so it was perhaps not strictly necessary).

It is to spammy in some countries/regions/cities where cash/cash-only is the norm. However it is a NoCountriesExcept with 4 countries and I expected that there are more countries (or parts like big cities) where it could be interesting.

Do you (or anyone else) have such example region where it would be useful (i.e. where you'd be using it)? If so, I guess we can enable it after adding the warning...

mnalis avatar May 11 '25 15:05 mnalis

But I probably should add a warning anyway

If the warning is short, I think it would be fine to simply have it in the text below the setting.

Helium314 avatar May 11 '25 16:05 Helium314

Looks good to me :slightly_smiling_face: Thanks for implementing this!

FloEdelmann avatar May 19 '25 09:05 FloEdelmann