SCEE icon indicating copy to clipboard operation
SCEE copied to clipboard

Overlapping controls with fast overlay switching

Open rusty-snake opened this issue 11 months ago • 9 comments

screenshot

share_2475685121763125165

How to Reproduce

  • Enable fast overlay switching

Expected Behavior

No overlapping

Does it happen in normal StreetComplete?

No fast overlay switching avaiable

Versions affected

SCEE 60.0

rusty-snake avatar Dec 29 '24 17:12 rusty-snake

Doesn't happen on my phone for whatever reason. I guess it's some issue with insets, similar to https://github.com/streetcomplete/StreetComplete/issues/6030

Helium314 avatar Dec 29 '24 22:12 Helium314

Doesn't happen on my phone for whatever reason.

Works fine on my Android 14 (Samsung Galaxy S23+) and Android 10 (Huawei P30 Pro) too.

Can you share what Android version / device model are you using @rusty-snake ?

mnalis avatar Dec 30 '24 03:12 mnalis

I can reproduce this behavior on my physical Android 15 (API 35) device and on the virtual Android 13 (API 33) machine. The effect is not quite as pronounced in the emulator, but it is more noticeable on the physical device. Virtual Device: image

Physical Device: image

Both are running on the latest Commit 9b95231 (freshly build from modified)

mcliquid avatar Dec 30 '24 09:12 mcliquid

Can you share what Android version / device model are you using

  • GrapheneOS (AOSP 15 QPR 1)
  • Pixel 6

OK, played with developer option. Removing the display cut-out moves from it to the right position (although a bit spacing at the top wouldn't be wrong). So it looks like it is positioned relative to the screen rather then relative to the rest of the app.

I also noticed that on small hights (landscape or split screen), it overlaps the bottom buttons.

rusty-snake avatar Dec 30 '24 09:12 rusty-snake

So it looks like it is positioned relative to the screen rather then relative to the rest of the app.

Thanks, so I'd say it's definitely something very similar to https://github.com/streetcomplete/StreetComplete/issues/6030 ("usable" screen size vs physical screen size).

I also noticed that on small hights (landscape or split screen), it overlaps the bottom buttons.

This is a side effect on most of the UI being compose now, but the quick-switch still using the "normal" Android views. At some point I'll switch everything to compose, but that's a lot of work (at least initially for learning compose) and not priority.

Helium314 avatar Dec 30 '24 10:12 Helium314

I can confirm this bug with Android 12. Compared to v59 the list is now cut off much earlier, requiring scrolling and is positioned wrong, so it's not in line with the icon on top:

v60

Screenshot_2024-12-30-11-07-15-440-edit_de.westnordost.streetcomplete.expert.jpg

v59

Screenshot_2024-12-27-12-35-37-595-edit_de.westnordost.streetcomplete.expert.jpg

RubenKelevra avatar Dec 30 '24 10:12 RubenKelevra

I wonder if https://github.com/streetcomplete/StreetComplete/pull/6074 might've helped with that... We should see on the next release :man_shrugging:

mnalis avatar Jan 07 '25 11:01 mnalis

Still a problem in 60.1

rusty-snake avatar Jan 12 '25 22:01 rusty-snake

  • probably related: https://github.com/streetcomplete/StreetComplete/issues/6098

mnalis avatar Jan 22 '25 03:01 mnalis