neko icon indicating copy to clipboard operation
neko copied to clipboard

Test regexp_matched_num PR

Open RblSb opened this issue 3 years ago • 2 comments

Want to see green https://github.com/HaxeFoundation/neko/pull/223

RblSb avatar Mar 04 '22 12:03 RblSb

Okay, so that nmatchs groups count doesnt exist in pcredata typedef structure, so it should be ported from hxcpp implementation.

...Can we skip neko part for regex.matchedNum() in https://github.com/HaxeFoundation/haxe/pull/10290, guys?

RblSb avatar Mar 04 '22 12:03 RblSb

The code changed slightly when porting to pcre2. I can try to fix it because it wasn't too long ago when I ported it.

tobil4sk avatar Mar 04 '22 16:03 tobil4sk

@Simn can this be merged? This closes #223 and unblocks https://github.com/HaxeFoundation/haxe/pull/10290, so maybe one less neko release will be required in future

RblSb avatar Mar 26 '23 14:03 RblSb