Tdarr_Plugins icon indicating copy to clipboard operation
Tdarr_Plugins copied to clipboard

Compare FS Ratio Live - engagment handling changes

Open quadcom opened this issue 11 months ago • 3 comments

**moved from core issues

When this step is triggered, it will cancel the encoding process by throwing an error on the encode node. This immediately drops the job into the error bin. But there could be a better way of handling this situation. Yes, it should stop the encoding process but there should be a path for the job to go for alternate processing or alternate job management.

In my case, if the encoding is going to be larger than the existing file, I would still want the extra content to be removed (off lang SRT, extra audio tracks etc) and the resulting streams remuxed with my stream tags on the 0track stream to keep track of what has gone through the system. At present this is not an option and the job simply errors out and the file stays as is. If I were to use the error path from the encoder node, ANY error would be sent down the alternate path which is not appropriate as encodes could fail for any number of reasons.

393961929-818592c2-b3ef-422a-904c-32ebea0f29f1

Describe the solution you'd like Add a secondary output path for the live ratio monitoring to direct jobs that have triggered the cancellation down a different path in the flow. Ensure the encoding process disregards cancel signals from this node so the job is not tracked as an error.

Describe alternatives you've considered There are no alternative approaches to handle this situation that I could determine. Please correct me if I am wrong on this.

quadcom avatar Dec 19 '24 22:12 quadcom

Bumping....

quadcom avatar Jan 06 '25 19:01 quadcom

  You can check if this plugin caused an error by using 'Check Flow Variable' and checking if 
  {{{args.variables.liveSizeCompare.error}}} is true.

Would this not solve the problem? So you could either use the error handle on the plugin or can use On Flow Error to catch an error that happens anywhere, then check if the error is to do with size compare.

HaveAGitGat avatar Jan 26 '25 21:01 HaveAGitGat

  You can check if this plugin caused an error by using 'Check Flow Variable' and checking if 
  {{{args.variables.liveSizeCompare.error}}} is true.

Would this not solve the problem? So you could either use the error handle on the plugin or can use On Flow Error to catch an error that happens anywhere, then check if the error is to do with size compare.

Sorry for the delay getting back here.

I'm not sure how that would work out. Would I put that on the red path of the Execute command?

From a visual flow perspective, taking the flow from the red path on the Compare Ratio Live node would make more sense since it was that node that cancelled the current process. The suggested solution involves adding another node to handle a specific use case.

Also, looking at the On Error Flow node, there is no conditional filtering so that would mean all errors would end up going down that node path. I would then have to build in filtering just for that situation. It seems to me that it's creating more node paths that add confusion to what the flow is trying to achieve.

If the Compare Ratio Live node passed the original filename out the red path of the node, that would solve the issue. It could then be passed to other nodes for processing or not connected to anything and error out as normal.

quadcom avatar Feb 10 '25 21:02 quadcom