HandBrake icon indicating copy to clipboard operation
HandBrake copied to clipboard

Auto dark mode in flatpak version

Open Zahrun opened this issue 1 year ago • 9 comments

Description of the feature or enhancement you'd like to see in HandBrake

Handbrake appears in white in the flatpak version when my system is in darkmode

What Operating System are you running?

Tuxedo OS 3

What version of HandBrake are you running?

No response

Where did you download HandBrake from?

No response

Activity Log, Crash Log or any other details

No response

Zahrun avatar May 06 '24 18:05 Zahrun

This should already be working. Do other GTK applications installed as Flatpak change theme correctly?

robxnano avatar May 12 '24 22:05 robxnano

Interestingly, this issue started for me after updating to Handbrake v1.8.0. Could this be related to the migration of the UI to GTK 4? Running Fedora 40 KDE....other GTK apps seem to be fine.

Edit: Just downgraded Handbrake to 1.7.3 and dark mode works fine.

hb_1 7 3

hb_1 8 0

r2rX avatar May 24 '24 12:05 r2rX

Oh, it seems to work for me today with 1.8.0. Can you check on your side @r2rX ?

Zahrun avatar Jun 02 '24 12:06 Zahrun

Oh, it seems to work for me today with 1.8.0. Can you check on your side @r2rX ?

Unfortunately, it's still not operating in dark mode.

r2rX avatar Jun 02 '24 12:06 r2rX

What system/DE/WM do you use?

Zahrun avatar Jun 02 '24 12:06 Zahrun

What system/DE/WM do you use?

Fedora 40 KDE, Plasma 6.0.5, Kwin......essentially, the defaults for Fedora KDE.

             .',;::::;,'.                xxxxx@fedora 
         .';:cccccccccccc:;,.            ----------- 
      .;cccccccccccccccccccccc;.         OS: Fedora Linux 40 (KDE Plasma) x86_64 
    .:cccccccccccccccccccccccccc:.       Host: ROG Strix G513QY 1.0 
  .;ccccccccccccc;.:dddl:.;ccccccc;.     Kernel: 6.8.11-300.fc40.x86_64 
 .:ccccccccccccc;OWMKOOXMWd;ccccccc:.    Uptime: 2 hours, 59 mins 
.:ccccccccccccc;KMMc;cc;xMMc:ccccccc:.   Packages: 3464 (rpm), 30 (flatpak) 
,cccccccccccccc;MMM.;cc;;WW::cccccccc,   Shell: bash 5.2.26 
:cccccccccccccc;MMM.;cccccccccccccccc:   Resolution: 1920x1080 
:ccccccc;oxOOOo;MMM0OOk.;cccccccccccc:   DE: Plasma 6.0.5 
cccccc:0MMKxdd:;MMMkddc.;cccccccccccc;   WM: kwin 
ccccc:XM0';cccc;MMM.;cccccccccccccccc'   Theme: Breeze-Dark [GTK2], Breeze [GTK3] 
ccccc;MMo;ccccc;MMW.;ccccccccccccccc;    Icons: breeze-dark [GTK2/3] 
ccccc;0MNc.ccc.xMMd:ccccccccccccccc;     Terminal: konsole 
cccccc;dNMWXXXWM0::cccccccccccccc:,      CPU: AMD Ryzen 9 5900HX with Radeon Graphics (16) @ 4.890GHz 
cccccccc;.:odl:.;cccccccccccccc:,.       GPU: AMD ATI Radeon RX 6700/6700 XT/6750 XT / 6800M/6850M XT 
:cccccccccccccccccccccccccccc:'.         GPU: AMD ATI Radeon Vega Series / Radeon Vega Mobile Series 
.:cccccccccccccccccccccc:;,..            Memory: 6519MiB / 31484MiB 
  '::cccccccccccccc::;,.

r2rX avatar Jun 02 '24 12:06 r2rX

I’m on Plasma 6.0.4, so you are more up to date. Sorry, I don’t know what changed for it to work now on my side.

Zahrun avatar Jun 02 '24 12:06 Zahrun

I appreciate the intent. If there are any changes, I'll provide the update/s here.

r2rX avatar Jun 02 '24 15:06 r2rX

You can install Flatseal to edit things more easily. Within Flatseal, select Handbrake then scroll down to the Environment Variables and remove "GTK_THEME=Breeze" and the dark theme shows. At least it did for me. Just did this now and it worked.

Antipokemon avatar Jun 22 '24 22:06 Antipokemon