HandBrake icon indicating copy to clipboard operation
HandBrake copied to clipboard

Request to disable preview on Handbrake GUI screen

Open maxime506 opened this issue 7 years ago • 22 comments

Hi there,

The newer version of the handbrake contains preview on the "summary" tab and I have no option to disable it. I encode videos that may contain sensitive materials and I don't want them in full display. The older versions don't have such problems.

Is it possible to include such an option to disable preview for future releases or is there a way to disable that?

Thanks. screenshot

Moderator Note:

  • [x] Windows
  • [x] Mac
  • [ ] Linux

maxime506 avatar Apr 09 '18 15:04 maxime506

I suppose this could be an option in the preferences. Perhaps the other developers will want to weigh in.

bradleysepos avatar Apr 09 '18 16:04 bradleysepos

Thanks for the reply.

Yup I search everywhere in the preference section and I cannot see any option to disable that.

maxime506 avatar Apr 09 '18 16:04 maxime506

Correct, there is currently no option to disable the image on the summary tab.

bradleysepos avatar Apr 09 '18 16:04 bradleysepos

I hope they can enable that switch. Shouldn't be too hard but very handy. :)

maxime506 avatar Apr 09 '18 16:04 maxime506

No objections. Not really a problem I'd considered but makes sense. For such a trivial change.

sr55 avatar Apr 09 '18 17:04 sr55

Could not agree more (= vote for having such an option in the preferences).

tjsuominen avatar Apr 10 '18 05:04 tjsuominen

Targeting for 1.2.0 but more likely to land after it's released.

bradleysepos avatar Sep 04 '18 07:09 bradleysepos

Then it would be okay to disable preview generation by the underlying system, to speed up init? I've just brushed through the referenced commit. I'm wondering, if one would want it asap it could be a low level switch which would work for all GUIs, it would just display a blank placeholder image instead.

ghost avatar Sep 04 '18 07:09 ghost

@Zexaron To clarify my comment, this is already implemented on Windows, both nightly builds and 1.1.1. Other platforms have made no progress.

bradleysepos avatar Sep 04 '18 07:09 bradleysepos

I'm wondering, if one would want it asap it could be a low level switch which would work for all GUIs

I do not believe this is feasible.

bradleysepos avatar Sep 04 '18 07:09 bradleysepos

@bradleysepos Oh, thank for clearing that up, that's what the checkmark is for ofcourse.

ghost avatar Sep 04 '18 14:09 ghost

Then it would be okay to disable preview generation by the underlying system, to speed up init?

No, previews are used to determine source characteristics that are required to properly fill in the initial encode settings for a file.

jstebbins avatar Sep 04 '18 17:09 jstebbins

@jstebbins @galad87 This is implemented on Windows for some time, any chance you would like to look at this for the other GUIs?

bradleysepos avatar Feb 28 '19 15:02 bradleysepos

Well, LinGUI has had that preview since day 1 and nobody ever complained until it showed up in the WinGUI. Windows users are apparently freakier that Linux users :wink:

But yes, I'll look into adding a preference option that disables it. When disabled, I'll probably show the HandBrake Logo in it's place.

jstebbins avatar Feb 28 '19 15:02 jstebbins

Added to the the Mac Gui in 98053d85d7aa6ce364a8a9e65fa0895289fdefb5 .

galad87 avatar Aug 30 '19 10:08 galad87

Works on macOS. Perhaps the SMPTE bars could be added to the other GUIs for parity.

bradleysepos avatar Sep 08 '19 03:09 bradleysepos

The more I see the SMPTE color bars on macOS, I think personally I'd rather have nothing displayed when no source is loaded. The bars are a bit distracting for my taste, calling attention to an area that warrants none.

If some still want the bars as an option, could it be a preference?

Show on summary tab:

  • Source preview
  • SMPTE color bars
  • None

In which case the default (Source preview) or None would not show the SMPTE color bars when no source is loaded.

bradleysepos avatar Sep 27 '19 12:09 bradleysepos

Alternatively, the SMPTE color bars could only be shown when a source is loaded and source preview is disabled. That way, they are never shown at startup when no source is loaded, regardless of other settings.

bradleysepos avatar Sep 27 '19 12:09 bradleysepos

LinGui shows a large version of the HB logo

jstebbins avatar Sep 27 '19 15:09 jstebbins

Did this ever get implemented? I have no need for the Summary pics, and would like to speed things up. I am using the Windows version. If it is implemented, I cannot find it in the latest release.

BrentHathaway avatar Apr 30 '20 12:04 BrentHathaway

On Windows and macOS, yes. But it won't speed up anything.

galad87 avatar Apr 30 '20 12:04 galad87

To be clear, this issue is about disabling display of the preview for privacy reasons. This issue is not about speeding anything up. The previews are still generated even if the display is disabled as they are needed in order to determine the settings to use during the transcode (like crop, framerate, audio samplerate, etc).

jstebbins avatar Apr 30 '20 14:04 jstebbins