svelte-adapter-appengine icon indicating copy to clipboard operation
svelte-adapter-appengine copied to clipboard

Published 20 hours ago • verified publisher icon HalfdanJ

Copy package-lock.json too

Open j-frost opened this issue 2 years ago • 2 comments

Currently, AppEngine complains during upload:

Updating service [default]...⠶WARNING: *** Improve build performance by generating and committing package-lock.json.

If this is not some kind of config error on my part, I'll be happy to submit a PR for this.

j-frost avatar Oct 30 '23 16:10 j-frost

It's not on your part. It is a warning, but i've been ignoring it since I don't think it actually has any meaningful impact in this case, since very few dependencies are actually installed in appengine.

HalfdanJ avatar Jan 01 '24 20:01 HalfdanJ

It seems to be good practice probably, gets rid of warning and does no harm probably 🤔

novakma2 avatar Jan 22 '24 16:01 novakma2