custom-metrics icon indicating copy to clipboard operation
custom-metrics copied to clipboard

Published 20 hours ago • verified publisher icon HTTPArchive

Add an `iframes` custom metric

Open adamsilverstein opened this issue 2 years ago • 3 comments

Based on the images metric, this one enumerates iframes present on the page including their:

  • url
  • width & height
  • naturalWidth and naturalHeight (for example when when w/h altered by CSS)
  • inViewport

adamsilverstein avatar Aug 10 '23 22:08 adamsilverstein

Most of this already exists in the almanac custom metric: https://github.com/HTTPArchive/custom-metrics/blob/main/metric-summary.md#iframes

We should enhance that. Though maybe there’s a good argument to move it to its own file while doing that. WDYT @rviscomi ?

tunetheweb avatar Aug 10 '23 22:08 tunetheweb

I'd like to move more towards grouping custom metrics by chapter, ie markup.js for things like this.

rviscomi avatar Sep 11 '23 13:09 rviscomi

Reminder @adamsilverstein . Wanna update the almanac one short term? Or take on the moving of this to markup.js at the same time as doing your updates?

tunetheweb avatar Oct 09 '23 11:10 tunetheweb