Gregor Hartmann

I agree but this is a breaking change which silently breaks things. We should add our deprecation message for one release before changing it. Maybe we need to silence the...

That sounds reasonable.

The rtcfifo.put() also does not document what happens when the fifo is full

The ws2812_effects module consists of two main functionalities which are interwoven and should be separated. 1. the player, which repeatedly updates the LED strip with the newly calculated effect. 2....

I have been thinking about this. It certainly would be good to allow individual effects in Lua but on the other hand executing some effects that change many pixels individually...

The relevant issue would be #1223? How could I include my own configs after this PR? As I would not only have my own user_config but also user_modules and user_version...

Unfortunately this issue is valid again. I would suggest to fix it by changing the doc to connect_cb and disconnect_cb. That would better match the other callbacks.

Is this really done? Above we mention > Furthermore, we can add a new page to our documentation that points to the wiki page. And after all it's "do good...

This is not associated with the drop

> They way that I would phrase this is that the _default_ build is 5.1 based. Post drop, anyone can opt to build the 5.1 @TerryE its not quite true...