LLDebugTool
LLDebugTool copied to clipboard
HDB-Li
Please remove the CocoaPods ping
Hi!
I think people are shipping this check to production devices and have been the cause of downtime on the CocoaPods website quite a few times. Last year I added code specifically to remove your pod from the website: http://cocoapods.org/pods/LLDebugTool
I don't think I can ever remove that code now, but at least you can remove the check to give our servers a chance to be less busy
Adding the offending code for reference: https://github.com/HDB-Li/LLDebugTool/blob/5775a43dbddb9a3e550c8078c60ebd16dd796e5a/LLDebugTool/DebugTool/LLDebugTool.m#L184-L209
The condition is defaulted to YES here:
https://github.com/HDB-Li/LLDebugTool/blob/750ed3a6f341fa67330fa36e00bc67d9da4d812c/LLDebugTool/DebugTool/LLConfig.m#L112
You can set autoCheckDebugToolVersion to disable this request. Also this check is actually invalid. I can't get the version number correctly. I will remove it later.
Heh, yeah, I banned your pod page from showing on the CocoaPods website - basically someone shipped your pod to production and we get taken down by their users :D
@orta I see. Thanks, My mistake, I will remove it tonight and release it on next version. 😆
@orta One more question, When I removed this code, Could you cancel banned my pod in future?
I just wanted to push the new version to the user and add a property to turn it off. I don't think my pod has such a large number of users that would cause DDS attacks on Cocoa pods. So maybe cancel banned my pod in future? 😢
I'm not part of CocoaPods, just a random opinion: "in the future" could potentially be far away in time depending on the rate of adoption of your new version. So you may better try to get yourself a second pod name (like 'LLDebugTool2' as an example) which doesn't have any release scraping its CocoaPods page, and advertise it around as the replacement of your deprecated pod.
Technically, I believe you can have multiple podspecs files in the same repository, so that both the old pod name and the new one would get updates until a safe version gets largely adopted.
Yeah, I'm open to removing that code but it's at many requests per-second today.
It'll take a long time for developers to update your library, then to update their apps, then for users to update their apps. I have no idea when I can undo it though - perhaps once it starts looking like a request a minute or two.
@orta I'm removed the CocoaPods ping and release a new version, How long will LLDebugTool can be accessed normally in cocoapods?
So badly..... Does this affect people's ability to search and install my pod through cocoapods?
Nope, not really - to give you some perspective: for every 1 normal website page view we get about 20 pings from this code (see the screenshot above)
@Coeur's point that you can re-name your library is honestly one of the best ideas
@orta Will this affect when pod install or pod search my pod? Renaming is a very bad idea and the worst way. If it doesn't affect pod install or pod search, the scope of influence should not be particularly large. I can wait until the frequency of this request falls. If pod install or pod search is affected, I will probably need to rename it.
For individual developers, the loss of renaming is too great. 😭
I believe the code Orta added only blocks your page on the CocoaPods website and not in trunk so install, etc should work. It’s probably easiest to try for yourself on a blank project :)