mkdocs-rss-plugin
mkdocs-rss-plugin copied to clipboard
fix(material_social): use cards_dir to build cards url for page
This should fix #319
The path building is based on https://github.com/squidfunk/mkdocs-material/blob/396c493f4774fa0bafeada5d0b555d02193557e8/src/plugins/social/plugin.py#L339-L362
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 81.46%. Comparing base (
c2525f5) to head (0370428). Report is 17 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #354 +/- ##
==========================================
+ Coverage 81.12% 81.46% +0.34%
==========================================
Files 11 11
Lines 747 750 +3
Branches 125 124 -1
==========================================
+ Hits 606 611 +5
+ Misses 97 96 -1
+ Partials 44 43 -1
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 81.46% <100.00%> (+0.34%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files with missing lines | Coverage Δ | |
|---|---|---|
| ...lugin/integrations/theme_material_social_plugin.py | 76.61% <100.00%> (+2.23%) |
:arrow_up: |
Hi @kanru ,
Thanks for your PR!
Sorry, CI was broken so I've fixed it in #357. Can you rebase your branch on origin/main please?
Can you also apply contributing guidelines, to make pre-commit.ci happy? I'll review it once everything is green here :).
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
@Guts done!
Hey @kanru,
I'm back to this project for a piece of free time and reviewing your PR, I found out that there is still no unit tests. So I've pushed it https://github.com/kanru-contrib/mkdocs-rss-plugin/pull/1
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Hey @kanru,
I'm back to this project for a piece of free time and reviewing your PR, I found out that there is still no unit tests. So I've pushed it kanru-contrib#1
Thanks for spending time on maintaining this project! I don't really write any python so just figuring out how to fix the issue and use the right style had already exhausted me. Thanks for writing the unit tests.
Thanks @kanru. The failing test is unrelated so I'll fix it later in a future PR. Time to merge has come!