mkdocs-rss-plugin icon indicating copy to clipboard operation
mkdocs-rss-plugin copied to clipboard

fix(material_social): use cards_dir to build cards url for page

Open kanru opened this issue 9 months ago • 4 comments

This should fix #319

The path building is based on https://github.com/squidfunk/mkdocs-material/blob/396c493f4774fa0bafeada5d0b555d02193557e8/src/plugins/social/plugin.py#L339-L362

kanru avatar Feb 25 '25 09:02 kanru

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.46%. Comparing base (c2525f5) to head (0370428). Report is 17 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #354      +/-   ##
==========================================
+ Coverage   81.12%   81.46%   +0.34%     
==========================================
  Files          11       11              
  Lines         747      750       +3     
  Branches      125      124       -1     
==========================================
+ Hits          606      611       +5     
+ Misses         97       96       -1     
+ Partials       44       43       -1     
Flag Coverage Δ
unittests 81.46% <100.00%> (+0.34%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...lugin/integrations/theme_material_social_plugin.py 76.61% <100.00%> (+2.23%) :arrow_up:

... and 3 files with indirect coverage changes

codecov[bot] avatar Feb 25 '25 15:02 codecov[bot]

Hi @kanru ,

Thanks for your PR!

Sorry, CI was broken so I've fixed it in #357. Can you rebase your branch on origin/main please?

Can you also apply contributing guidelines, to make pre-commit.ci happy? I'll review it once everything is green here :).

Guts avatar Feb 25 '25 16:02 Guts

@Guts done!

kanru avatar Feb 27 '25 12:02 kanru

Hey @kanru,

I'm back to this project for a piece of free time and reviewing your PR, I found out that there is still no unit tests. So I've pushed it https://github.com/kanru-contrib/mkdocs-rss-plugin/pull/1

Guts avatar May 22 '25 20:05 Guts

Hey @kanru,

I'm back to this project for a piece of free time and reviewing your PR, I found out that there is still no unit tests. So I've pushed it kanru-contrib#1

Thanks for spending time on maintaining this project! I don't really write any python so just figuring out how to fix the issue and use the right style had already exhausted me. Thanks for writing the unit tests.

kanru avatar May 22 '25 22:05 kanru

Thanks @kanru. The failing test is unrelated so I'll fix it later in a future PR. Time to merge has come!

Guts avatar May 23 '25 17:05 Guts