ngx-image-drawing icon indicating copy to clipboard operation
ngx-image-drawing copied to clipboard

Image save not happening correctly

Open venomoustoad opened this issue 5 years ago • 6 comments

This seems to be a fundamental issue with painting done on the canvas, the lines are either getting shifted or some of the actions are not reflecting correctly in the output saved file I am using fabric 3.2.0 and ngx-image-drawing 1.2.4

venomoustoad avatar Jan 31 '20 13:01 venomoustoad

This is the case even with the demo project saved online.

venomoustoad avatar Jan 31 '20 14:01 venomoustoad

This is a bug we saw a few time but we have no time presently to fix it

valentintintin avatar Jan 31 '20 14:01 valentintintin

So has this worked correctly(as in 100% in a particular version) in previous versions or has there always been a few cases where the bug occurred in the past in all versions? I could try look for a solution too. i.e basically is this a regression issue or has this always been there at certain times.

venomoustoad avatar Jan 31 '20 14:01 venomoustoad

This is unfortunately a regression. Try the version 1.2.1

valentintintin avatar Jan 31 '20 14:01 valentintintin

Yes 1.2.1 works correctly!

venomoustoad avatar Jan 31 '20 14:01 venomoustoad

The problem seems to be fixed if forceSizeExport (line 19 in image-drawing.component.ts) is set to true (it currently defaults to false). So you could do

<image-drawing forceExportSize="true"> </image-drawing>

to get around this while the bug isn't fully fixed yet.

charliejmoore avatar Mar 21 '20 20:03 charliejmoore