treetracker-web-map-client icon indicating copy to clipboard operation
treetracker-web-map-client copied to clipboard

Refactor: Change the bounds format to follow google map

Open QuanGiap opened this issue 2 years ago • 1 comments
trafficstars

Description

Change the URL coordinate to follow the Google format map. Fixes #658

Type of change

  • [x] New feature (non-breaking change which adds functionality)

Video

In this video, first you can see the coordinate URL will be changed from ".../?bounds=,,," to "../?view=,,<zoomLevel>z". The website will still work if the link contains bounds

screen-capture (1).webm

How Has This Been Tested?

  • [x] Cypress integration
  • [x] Cypress component tests
  • [x] Jest unit tests

Checklist:

  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes

QuanGiap avatar Sep 09 '23 21:09 QuanGiap

@sebastiangaertner This is an overdue requirement that we want to use more better format to present the map view, take a look at the video, and please help us consider the impact of this change?

dadiorchen avatar Sep 11 '23 02:09 dadiorchen