treetracker-web-map-client icon indicating copy to clipboard operation
treetracker-web-map-client copied to clipboard

Published 20 hours ago • verified publisher icon Greenstand

Fix page layout embedded

Open Ewan88 opened this issue 2 years ago • 3 comments
trafficstars

Description

This change sets the local storage value for embed from the url - previously it was always false, regardless of url param.

Also fixes a CSS issue with a horizontal scrollbar appearing, despite there being no extra content.

Fixes #1674

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • [x] Cypress integration
  • [x] Cypress component tests
  • [x] Jest unit tests

Checklist:

  • [x] I have performed a self-review of my own code
  • [x] New and existing unit tests pass locally with my changes

Ewan88 avatar Jul 05 '23 20:07 Ewan88

@Ewan88 thank you for you contribution! can you split this to two PR, it is good for code maintenance and review.

dadiorchen avatar Jul 06 '23 07:07 dadiorchen

@dadiorchen #1683

Ewan88 avatar Jul 06 '23 10:07 Ewan88

@Ewan88 there is a conflict, can you solve it?

dadiorchen avatar Jul 07 '23 02:07 dadiorchen