treetracker-web-map-client icon indicating copy to clipboard operation
treetracker-web-map-client copied to clipboard

Page layout disorder when use the parameter query: ?embed=true

Open dadiorchen opened this issue 2 years ago • 6 comments
trafficstars

https://map.treetracker.org/organizations/178?bounds=-253.12500000000003,-80.11856387883782,253.12500000000003,80.11856387883782&embed=true

When visiting this url, as shown below, there is a non-embed layout showing up and disappearing quickly before the correct layout show up.


Some hints:

  • Please read our readme for more information/guide/tutorial.
  • For design guidelines checkout our Figma design.
  • Here is an engineering book in Greenstand.
  • To know more about our organization, visit our website.
  • If you want to join the slack community (some resources need the community member's permission), please leave your email address.

dadiorchen avatar Jul 04 '23 01:07 dadiorchen

I could not reproduce this issue locally however I did notice a couple of other issues around this - the above mentioned pull request addresses those issues.

I also noticed some behaviour where the embed params would be removed when the user pans the map. It might be worth investigating that issue separately - possibly along with #658

I am curious if it's worthwhile to add integration tests for the embed behaviour? My fears are that such tests could be extremely flaky.

Ewan88 avatar Jul 05 '23 20:07 Ewan88

The missing params might be solved by this: https://github.com/Greenstand/treetracker-web-map-client/pull/1661

Yea, I agree, the integration test costs maintaness, let's just do it when necessary.

@Ewan88 if you are interested to join our community, please leave your email, I would be happy to invite you

dadiorchen avatar Jul 06 '23 07:07 dadiorchen

Oh, sorry I forgot to paste the video: https://dadior.s3.ap-northeast-1.amazonaws.com/Screen%20Recording%202023-07-06%20at%203.34.00%20PM.mp4

Take a look the video, when reload the page, a un-embed layout flash in and out.

dadiorchen avatar Jul 06 '23 07:07 dadiorchen

If this issue is open i can work on this

vijayasree19 avatar Aug 22 '23 17:08 vijayasree19

Feel free to pick this up. I don't think my attempted fix resolved it and I haven't delved further

On Tue, 22 Aug 2023, 18:05 vijayasree19, @.***> wrote:

If this issue is open i can work on this

— Reply to this email directly, view it on GitHub https://github.com/Greenstand/treetracker-web-map-client/issues/1674#issuecomment-1688595076, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJXLUY3WUKY7IEZ5L2IB5ODXWTRF3ANCNFSM6AAAAAAZ5BU3CE . You are receiving this because you were mentioned.Message ID: @.***>

Ewan88 avatar Aug 22 '23 21:08 Ewan88

@vijayasree19 yes, please go ahead!

dadiorchen avatar Aug 23 '23 08:08 dadiorchen