treetracker-web-map-client icon indicating copy to clipboard operation
treetracker-web-map-client copied to clipboard

Fix broken test in `cwm` branch

Open dadiorchen opened this issue 2 years ago • 4 comments
trafficstars

in this PR, https://github.com/Greenstand/treetracker-web-map-client/pull/1668 The ci reported error: https://github.com/Greenstand/treetracker-web-map-client/actions/runs/5430146328?pr=1668

We need to fix them.


Some hints:

  • Please read our readme for more information/guide/tutorial.
  • For design guidelines checkout our Figma design.
  • Here is an engineering book in Greenstand.
  • To know more about our organization, visit our website.
  • If you want to join the slack community (some resources need the community member's permission), please leave your email address.

dadiorchen avatar Jul 03 '23 07:07 dadiorchen

@RubenSmn I just open the CI for branches now, seems there are some broken test in cwm

dadiorchen avatar Jul 03 '23 07:07 dadiorchen

@dadiorchen are we using the .env.test env file when running the tests? The flag that we use to disable the feature of getting the theme from the backend is correct. Could it be that we're using the .env.development env file when running the tests?

RubenSmn avatar Jul 10 '23 09:07 RubenSmn

Yea, I think we are using .env.development, I don't remember anything about .env.test related.

About the error, the unit test problem is easy, just we need to fix something related to cwm code.

For the integration test, I hope you can run it locally on the cwm branch, if that works on your side, I can help to find out what' cause the problem in this CI

dadiorchen avatar Jul 11 '23 10:07 dadiorchen

We we finished this, then we can use the CI to protect the cwm branch, I think this is meaniful.

dadiorchen avatar Jul 11 '23 10:07 dadiorchen