treetracker-web-map-client icon indicating copy to clipboard operation
treetracker-web-map-client copied to clipboard

Adopt JSDoc for documenting our code

Open RubenSmn opened this issue 2 years ago • 6 comments
trafficstars

Proposition

Adopt JSDoc for our code documentation.

Why

We're using a lot of custom components, it is not always clear what kind of props the component expect us to pass or what types the props need to be.

I think this could be a good alternative to something like TypeScript, where we would have to change the entire code base. Using JSDoc we can incrementally update our documentation of our custom components and utility functions. This way we can still get the benefits of auto completion and such.


Some hints:

  • Please read our readme for more information/guide/tutorial.
  • For design guidelines checkout our Figma design.
  • Here is an engineering book in Greenstand.
  • To know more about our organization, visit our website.
  • If you want to join the slack community (some resources need the community member's permission), please leave your email address.

RubenSmn avatar Jun 30 '23 12:06 RubenSmn

@dadiorchen @khalatevarun what are you guys' opinions about this?

RubenSmn avatar Jun 30 '23 12:06 RubenSmn

I'm good with this, so this is a way we can use autocompletion without TS?

dadiorchen avatar Jul 01 '23 01:07 dadiorchen

hi, I'd like to contribute to the documentation of this project.

elidakirigo avatar Jul 01 '23 10:07 elidakirigo

Is there any particular reason to not adopt typescript in our codebase? @dadiorchen @RubenSmn

khalatevarun avatar Jul 06 '23 03:07 khalatevarun

@khalatevarun maybe we can consider typescript at the beginning of the app, but now I don't think it worth the effort to do a big refactor.

dadiorchen avatar Jul 07 '23 02:07 dadiorchen

I agree with Dadior, the refactor would a thing we would have to do in a single change. With JSDoc we can incrementally document our code.

RubenSmn avatar Jul 10 '23 09:07 RubenSmn