treetracker-web-map-client icon indicating copy to clipboard operation
treetracker-web-map-client copied to clipboard

Display 500 error page inappropriate.

Open dadiorchen opened this issue 2 years ago • 7 comments
trafficstars

When visiting page, if the resource (wallet name or so) doesn't exist, we shouldn't display 500 page, please display 404 instead.

for example: https://map.treetracker.org/wallets/8a0ce006-bb2d-40f3-8005-8c3080dca6d3

image

This is a good way to reproduce the problem: https://github.com/Greenstand/treetracker-web-map-client#how-to-connect-to-production-data-locally


Some hints:

  • Please read our readme for more information/guide/tutorial.
  • For design guidelines checkout our Figma design.
  • Here is an engineering book in Greenstand.
  • To know more about our organization, visit our website.
  • If you want to join the slack community (some resources need the community member's permission), please leave your email address.
  • More issues in this project: https://github.com/orgs/Greenstand/projects/26

dadiorchen avatar May 05 '23 07:05 dadiorchen

Hi there, if I get this issue assigned, where should I find the 404 design page or that would be up to me for design? thanks

Sdaewa avatar May 05 '23 08:05 Sdaewa

You don’t need to design anything, 404 and 500 page is there already, the issue is about how to jump to the correct error page.

Dadior Chen

在 2023年5月5日,16:55,Luis @.***> 写道:



Hi there, if I get this issue assigned, where should I find the 404 design page or that would be up to me for design? thanks

— Reply to this email directly, view it on GitHubhttps://github.com/Greenstand/treetracker-web-map-client/issues/1546#issuecomment-1535941312, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABL2QREHGCPJUX6S2GA35ETXES6A3ANCNFSM6AAAAAAXWXEQRM. You are receiving this because you authored the thread.Message ID: @.***>

dadiorchen avatar May 05 '23 09:05 dadiorchen

okay I understand now, I will work on it then, thanks

Sdaewa avatar May 05 '23 09:05 Sdaewa

@dadiorchen please check my pr.

Harshalyadav avatar May 05 '23 15:05 Harshalyadav

@Sdaewa seems @Harshalyadav have solved this, can you help review this PR?

dadiorchen avatar May 06 '23 01:05 dadiorchen

This is an issue open for everyone

dadiorchen avatar Jun 28 '23 07:06 dadiorchen

@Harshalyadav I remember your solution is good, but because the chaos of the branches so we closed it, can you pick your previous code and do a new PR again?

dadiorchen avatar Jun 28 '23 07:06 dadiorchen