graylog2-server icon indicating copy to clipboard operation
graylog2-server copied to clipboard

Link to input in message details

Open supahgreg opened this issue 3 years ago • 4 comments

This PR makes the Input name in the Received by section of message details a link to the Input on the Inputs page (if the Input still exists).

Description

This PR introduces aupport for linking and jumping (once) directly to an EntityListItem within an EntityList, and then uses that to link to an input from the Received by section of message details.

The ReviewBot items are unrelated to the changes in this PR, so I've skipped addressing them (for now).

Motivation and Context

Currently the details section links to the receiving node, but not the corresponding input. Being able to directly jump from a message to the related input on the Inputs page eliminates several manual steps.

Closes #2829.

How Has This Been Tested?

Verified I can click the message details input name/link and get to the corresponding input on the Inputs page.

Screenshots (if appropriate):

image image

image image

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Refactoring (non-breaking change)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] My code follows the code style of this project.
  • [x] My change requires a change to the documentation.
  • [x] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.

supahgreg avatar Aug 11 '22 19:08 supahgreg

@supahgreg: Thanks a lot for this PR! What do you think of opening a dropdown when clicking on the input name instead, which offers a couple of options, e.g. including/excluding this input from the search, or jumping to the inputs page (as implemented in your PR)?

dennisoelkers avatar Sep 08 '22 14:09 dennisoelkers

@dennisoelkers Sure, I'll look into that.

supahgreg avatar Sep 08 '22 17:09 supahgreg

@supahgreg: We can also take it from here, if you do not have the time for it.

dennisoelkers avatar Sep 09 '22 06:09 dennisoelkers

I should have time. Seems interesting :)

supahgreg avatar Sep 09 '22 11:09 supahgreg