Graphite icon indicating copy to clipboard operation
Graphite copied to clipboard

When text is modified in the Properties panel, it shifts around

Open Keavon opened this issue 2 years ago • 7 comments

Editing the text in the properties panel causes the position of the text in the document to shift (we need to update the position when the text changes, as the position is relative to the centre of the text). This only happens if the text has a scale other than 1x1 in X and Y.

Keavon avatar Apr 27 '23 02:04 Keavon

Is this still relevant? I'm failing to reproduce this (or don't understand what the bug exactly is).

milan-sedivy avatar Feb 25 '24 10:02 milan-sedivy

@milan-sedivy Here is a screen capture of the bug. The left side of the text should not move but does. text_shift.webm

0HyperCube avatar Feb 25 '24 11:02 0HyperCube

@0HyperCube just checking, do you expect this would cause any conflicts with your changes in #1589?

Keavon avatar Feb 25 '24 19:02 Keavon

This is to do with the transform pivot so so will conflict with #1558.

0HyperCube avatar Feb 25 '24 19:02 0HyperCube

Gotcha, I think that's acceptable if they conflict since it shouldn't be too big of a change.

Keavon avatar Feb 25 '24 19:02 Keavon

https://github.com/GraphiteEditor/Graphite/pull/1558 fixes this issue.

0HyperCube avatar Feb 25 '24 19:02 0HyperCube

Oh, in that case I'll mark it so it closes this.

Keavon avatar Feb 25 '24 19:02 Keavon