Graphiti icon indicating copy to clipboard operation
Graphiti copied to clipboard

Feature: Create better support for custom connections

Open cshadek opened this issue 2 years ago • 2 comments

There was discussion in #106 about enabling better support for custom connections and recent changes were made to make that easier to implement in #107, #108, and #109.

  1. Ideally it would be nice to have an easy way to declare connections with custom fields and edges with custom fields. I'm not exactly sure the best way to implement this, but it would be nice to have the customization and at the same time utilize the existing connection code, including slicing, etc.

@NeedleInAJayStack I know you mentioned you had begun to think about how this might be accomplished.

  1. In addition, maybe it makes sense to also think about the "connection of a protocol" issue where because Node needs to implement Encodable, it is currently not possible to have a connection of a Union or Interface. There is a fix, and that is to create a wrapper type, but that's obviously not the cleanest approach.

A possible solution to 2 was mentioned here: https://github.com/GraphQLSwift/Graphiti/issues/50#issuecomment-776896528

cshadek avatar Mar 13 '23 16:03 cshadek

Just put in a pull request that addresses item 1: https://github.com/GraphQLSwift/Graphiti/pull/112

NeedleInAJayStack avatar Mar 14 '23 04:03 NeedleInAJayStack

Well that was fast!

cshadek avatar Mar 14 '23 06:03 cshadek