bug: Theme is applied partially

[marcinjahn]

Is there an existing issue for this?

• [X] I have searched the existing issues

What happened?

I've been trying to apply a theme called "Alpha Mac". When I select the theme in Gradience, the Gradience window becomes properly themed:

However, when I log out and log back in, I see that:

• window backgrounds follow the theme (not all apps though)
• window controls (close, maximize) have 3 possible states:
  • in some apps they follow the Alpha Mac theme
  • in some apps they look like Adwaita (even though the rest of the theme is applied, like a background)
  • in some apps windows controls disappear completely, although they are still clickable

The window controls issue is kinda random. A given app may not display controls at all, and after another log out - log in, the controls are visible (but in the default Adwaita style).

To Reproduce

1. Apply Alpha Mac theme

Expected behavior

The theme should just work across all the apps.

Screenshots

No response

OS

Fedora Linux 36 (Workstation)

Version

0.3.1

Installation method

Flatpak from Flathub

Additional context

Code of Conduct

• [X] I agree to follow this project's Code of Conduct

[0xMRTT]

Did you tried with other themes ?

[marcinjahn]

Yeah, I did. I'm actually using "Pretty Purple" all the time. I think it is not as problematic as Alpha Mac, because it does not modify the window controls. There are a few apps that don't follow the Pretty Purple theme (like the Extensions Manager or Drawing). I have no idea why though.

[0xMRTT]

Are you using Extensions Manager as a flatpak ?

[marcinjahn]

Yes, it's from flathub, same as Gradience itself. Actually, many (maybe all?) flatpaks apps do not use the theme applied by Gradience, but rather the default light Adwaita theme. I surely did select the "LibAdwaita and GTK4" checkbox when applying the theme.

[0xMRTT]

Hmm, could you try:

flatpak override --reset
sudo flatpak override --filesystem=xdg-config/gtk-4.0
sudo flatpak override --filesystem=xdg-config/gtk-3.0

[marcinjahn]

That fixed the flatpak issue, thanks!

Maybe Gradience should invoke these when applying themes?

[marcinjahn]

I tried applying Alpha Mac again, and invoked the command you showed me. It didn't help with that issue unfortunately. Here's what some of the apps look like after log-out/log-in:

The window controls are missing in some apps, in others they are correctly displayed. I never see such an issue with Pretty Purple.

[tfuxu]

@0xMRTT Please move this issue to GradienceTeam/Community as this is an issue with Alpha Mac preset itself.

[tfuxu]

The window controls are missing in some apps, in others they are correctly displayed. I never see such an issue with Pretty Purple.

Can confirm it, probably author of this preset just forgot to add CSS rules for GTK 3 apps. (We should check presets before merging them next time)

[marcinjahn]

Could be, now when I launched Gradience, after applying Alpha Mac, I see this:

I think there are 2 issues here:

1. a community theme Alpha Mac (possibly Alpha Black and Alpha Dark as well) is broken?
2. Gradience does not show that the theme is broken until I apply it and logout/login.

[tfuxu]

Known issue, it's something with CSS parser we are using in Gradience, it will only cause issues if you are changing something in preset, and it got loaded with those errors.

[marcinjahn]

Known issue, it's something with CSS parser we are using in Gradience, it will only cause issues if you are changing something in preset, and it got loaded with those errors.

Not sure if that's what you meant, but I didn't change anything in the preset. I just applied the theme, didn't make any modifications to it.

[tfuxu]

1. a community theme Alpha Mac (possibly Alpha Black and Alpha Dark as well) is broken?

2. Gradience does not show that the theme is broken until I apply it and logout/login.

1. Yea, it is,
2. The preset itself isn't broken in this aspect, it's just that CSS parser is loading it in a broken way