web-stories-wp icon indicating copy to clipboard operation
web-stories-wp copied to clipboard

Images added as different sizes when dragging vs clicking

Open jauyong opened this issue 5 years ago • 4 comments

Bug Description

When you click to add an image to the page, it is added as one size. Then if you drag the same image to the page, it is added as a larger size.

Expected Behaviour

It should be consistent.

Screenshots

https://xwp.slack.com/archives/CCCAUAH6F/p1591724046225200

Additional Context

  • Plugin Version:
  • Operating System:
  • Browser:

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

Implementation Brief

jauyong avatar Jun 09 '20 17:06 jauyong

We could scale images (and shapes) up when dragging starts to the same size they would have, if just placed by clicking - and we could potentially use an animation similarly to this:

https://twitter.com/siddharthkp/status/1273868440923713536

CC @samitron7, @pbakaus, @o-fernandez.

barklund avatar Jun 19 '20 19:06 barklund

Drop behavior for images/video is in Figma now (added on Friday): https://www.figma.com/file/Cd9iacVknHK62RO4pRwb68/Stories-Editor?node-id=10064%3A0

merapi avatar Jun 23 '20 11:06 merapi

yep that behavior sgtm.

pbakaus avatar Jun 23 '20 18:06 pbakaus

@barklund Get outta here, can we do that animation please. Once the thumb hits the page, animate the resizing.

And Marcin and I chatted about all this on slack and I updated Figma for all things related to sizing when added to page on Figma. Let me know if any additional tickets are missing figma links.

samitron7 avatar Jun 25 '20 22:06 samitron7