web-stories-wp icon indicating copy to clipboard operation
web-stories-wp copied to clipboard

Published 20 hours ago • verified publisher icon GoogleForCreators

TypeScript: Convert `output` package

Open swissspidy opened this issue 3 years ago • 5 comments

swissspidy avatar Aug 09 '22 14:08 swissspidy

@swissspidy can I pick this I know this is blocked by @googleforcreators/elements, @googleforcreators/masks, @googleforcreators/element-library and @googleforcreators/animation packages. I would resolve the errors once those PR are merged.

amovar18 avatar Sep 27 '22 05:09 amovar18

It might not be the best issue to pick up, but you're definitely welcome to try if you want to :-)

swissspidy avatar Sep 28 '22 07:09 swissspidy

@swissspidy I did manage to convert the package should I raise a draft PR for the same?

amovar18 avatar Sep 28 '22 07:09 amovar18

Amazing! Yeah sure why not 👍 Then the team can provide feedback already in this early state

swissspidy avatar Sep 28 '22 07:09 swissspidy

@barklund @merapi see above, mind taking an early look at #12382?

swissspidy avatar Sep 28 '22 08:09 swissspidy

This ticket is blocking other package migration. Is there anyway we move this on?

spacedmonkey avatar Oct 13 '22 15:10 spacedmonkey

Feel free to provide feedback on #12382 if you'd like.

This should not be blocking anything else though. Other packages can be migrated even without the output package being fully migrated.

Check out the design-system package as prior art.

swissspidy avatar Oct 13 '22 17:10 swissspidy

FWIW this ticket is not the blocking factor. There are three other ones currently blocking it.

swissspidy avatar Oct 17 '22 09:10 swissspidy