skaffold
skaffold copied to clipboard
fix: backport Bazel build context fixes to v1
Fixes: #7864
Description
I've backported commits which fix the usage of Bazel artifact context. Now it's possible to put skaffold.yaml file to subfolder of bazel workspace and set context to a relative path.
Before:
skaffold-v1.39.2 version
v1.39.2
skaffold-v1.39.2 run -p k8s-usw2-dev-skaffold
WARN[0000] failed to detect active kubernetes cluster node platform. Specify the correct build platform in the `skaffold.yaml` file or using the `--platform` flag subtask=-1 task=DevLoop
Generating tags...
...
(18:34:17) INFO: Build completed successfully, 1 total action
build [***] failed: reading image "bazel-out/darwin_arm64-dbg-ST-4a519fd6d3e4/bin/***r/docker.tar": open bazel-out/darwin_arm64-dbg-ST-4a519fd6d3e4/bin/***/docker.tar: no such file or directory
skaffold-v1.39.2-patched version
v1.39.2-2-gc8d606d52
skaffold-v1.39.2-patched run -p k8s-usw2-dev-skaffold
WARN[0000] failed to detect active kubernetes cluster node platform. Specify the correct build platform in the `skaffold.yaml` file or using the `--platform` flag subtask=-1 task=DevLoop
Generating tags...
...
(18:34:45) INFO: Build completed successfully, 1 total action
Build [***] succeeded
Starting test...
Tags used in deployment:
...
Deployments stabilized in 3.686 seconds
You can also run [skaffold run --tail] to get the logs
Codecov Report
:exclamation: No coverage uploaded for pull request base (
v1@7ed1d72). Click here to learn what that means. The diff coverage isn/a.
@@ Coverage Diff @@
## v1 #7866 +/- ##
=====================================
Coverage ? 68.38%
=====================================
Files ? 563
Lines ? 26692
Branches ? 0
=====================================
Hits ? 18252
Misses ? 7173
Partials ? 1267
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Thanks for the PR @mikekamornikov! Currently I am restarting the Windows Integration Test job as there was a test error (but this is test error likely a flake unrelated to your changes). Once I can verify this is a flake and we have all tests passing we can merge this.