skaffold icon indicating copy to clipboard operation
skaffold copied to clipboard

Skaffold dev - don't exit if deployment is broken

Open HariSekhon opened this issue 4 years ago • 2 comments
trafficstars

Expected behavior

Expect the dev mode watcher to stay running while I fix manifests until the deployment stays working.

Actual behavior

Skaffold exits out if the deployment fails to pass the container status / health check.

This means I have to continually re-run skaffold dev each time I change the manifests until I get it working, somewhat defeating the purpose of the dev mode, as it's then not much different to running kubectl apply myself each time, which loses the aspect of automatic Continuous Development.

Information

  • Skaffold version: v1.27.0
  • Operating system: macOS
  • Installed via: Homebrew
  • Contents of skaffold.yaml:
apiVersion: skaffold/v2beta18
kind: Config
metadata:
  name: www
deploy:
  statusCheckDeadlineSeconds: 500  # app takes ages to pre-load cache and pass healthcheck
  kubeContext: mycontext
  kustomize:
    paths:
      - ../base
      - .

Steps to reproduce the behavior

With a deployment that fails to bring up its pods, and results in say CrashLoopBackoff, Skaffolds exits out.

$ skaffold dev --cleanup=false
....
 - mynamespace:deployment/www failed. Error: container blah terminated with exit code 1.
1/1 deployment(s) failed
$ (exited)

or

 - mynamespace:deployment/www failed. Error: container blah is backing off waiting to restart.
1/1 deployment(s) failed
$ (exited)

HariSekhon avatar Jul 14 '21 09:07 HariSekhon

hey @HariSekhon, hopping in here to say that this is something we'd like to work on soon. We can't give a delivery date right now but we just wanted to give that update

MarlonGamez avatar Jul 26 '21 20:07 MarlonGamez

related issue #4158

tejal29 avatar Aug 09 '21 18:08 tejal29

Dupe of #4158 which has recently been prioritized recently. Closing this issue and tracking the issue/progress in #4158

aaron-prindle avatar Nov 26 '22 20:11 aaron-prindle