python-docs-samples icon indicating copy to clipboard operation
python-docs-samples copied to clipboard

Add notebook testing

Open vuppalli opened this issue 5 years ago • 6 comments

In which file did you encounter the issue?

This issue is related to new notebook code that will be added to this repository. PR: https://github.com/GoogleCloudPlatform/python-docs-samples/pull/4389

Describe the issue

Add testing for notebooks to this repository after @sirtorry finishes his work on notebook testing with ai-platform-samples.

The notebook also includes testing setup code (first cell) and teardown code (last cell) that uploads resources to GCS and BigQuery. However, if the code fails, the teardown cell will not execute. There needs to be a resource cleanup script for this as well.

vuppalli avatar Jul 31 '20 18:07 vuppalli

(Accidental un-assign, meant to just add @ivanmkc.)

meredithslota avatar Mar 03 '21 00:03 meredithslota

Is this still required? All new Vertex AI notebooks live in https://github.com/GoogleCloudPlatform/vertex-ai-samples/tree/main/notebooks

ivanmkc avatar Jan 24 '22 17:01 ivanmkc

@bradmiro can you let me know if this repo needs a notebook testing CI?

ivanmkc avatar Jan 24 '22 17:01 ivanmkc

@ivanmkc does that repo have automated notebook testing? Maybe we can move the notebooks there.

@leahecole wdyt?

bradmiro avatar Jan 24 '22 23:01 bradmiro

Oooo that would be convenient. I know we have our data-science-onramp notebook but I also know these old samples are still kickin around https://github.com/GoogleCloudPlatform/python-docs-samples/tree/main/notebooks

If they seem like good candidates to move, let's do it, or if there's a process for onboarding a repo to notebook CI the @GoogleCloudPlatform/python-samples-owners and I would love to know it!

leahecole avatar Jan 25 '22 21:01 leahecole

Adding Lo to this old issue because they're making it happen!

leahecole avatar Apr 29 '22 14:04 leahecole