python-docs-samples
python-docs-samples copied to clipboard
Add notebook testing
In which file did you encounter the issue?
This issue is related to new notebook code that will be added to this repository. PR: https://github.com/GoogleCloudPlatform/python-docs-samples/pull/4389
Describe the issue
Add testing for notebooks to this repository after @sirtorry finishes his work on notebook testing with ai-platform-samples.
The notebook also includes testing setup code (first cell) and teardown code (last cell) that uploads resources to GCS and BigQuery. However, if the code fails, the teardown cell will not execute. There needs to be a resource cleanup script for this as well.
(Accidental un-assign, meant to just add @ivanmkc.)
Is this still required? All new Vertex AI notebooks live in https://github.com/GoogleCloudPlatform/vertex-ai-samples/tree/main/notebooks
@bradmiro can you let me know if this repo needs a notebook testing CI?
@ivanmkc does that repo have automated notebook testing? Maybe we can move the notebooks there.
@leahecole wdyt?
Oooo that would be convenient. I know we have our data-science-onramp notebook but I also know these old samples are still kickin around https://github.com/GoogleCloudPlatform/python-docs-samples/tree/main/notebooks
If they seem like good candidates to move, let's do it, or if there's a process for onboarding a repo to notebook CI the @GoogleCloudPlatform/python-samples-owners and I would love to know it!
Adding Lo to this old issue because they're making it happen!